Revert "feat(next-swc): Implement CJS optimizer" #50247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec8bf53.
ijjk
requested review from
timneutkens,
shuding,
a team,
huozhi and
feedthejim
as code owners
ijjk
added
area: tests
created-by: Next.js team
kdy1
approved these changes
May 24, 2023
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
This seems to be failing with the WASM builds so this reverts to allow further investigation x-ref: https://github.com/vercel/next.js/actions/runs/5062818601/jobs/9088828339 x-ref: https://github.com/vercel/next.js/actions/runs/5061364458/jobs/9085596546 x-ref: https://github.com/vercel/next.js/actions/runs/5062868910/jobs/9092170727 Reverts vercel#49972
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
### What? This reverts commit 6ebc725 / vercel#50247. ### Why? vercel#49972 is reverted due to bugs, and I'm retrying it. ### How? Closes WEB-1072 Closes WEB-1097 Closes NEXT-1156 (as it's reopened by the revert PR) fix vercel#48469 --------- Co-authored-by: Shu Ding <g@shud.in>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be failing with the WASM builds so this reverts to allow further investigation
x-ref: https://github.com/vercel/next.js/actions/runs/5062818601/jobs/9088828339
x-ref: https://github.com/vercel/next.js/actions/runs/5061364458/jobs/9085596546
x-ref: https://github.com/vercel/next.js/actions/runs/5062868910/jobs/9092170727
Reverts #49972